src/ic/x64/handler-compiler-x64.cc - Issue 540903002: Flatten property_kind into state. Add UNKNOWN as a state for dict-mode receivers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/x64/handler-compiler-x64.cc

Issue 540903002: Flatten property_kind into state. Add UNKNOWN as a state for dict-mode receivers (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add DCHECKs Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/x64/handler-compiler-x64.cc

diff --git a/src/ic/x64/handler-compiler-x64.cc b/src/ic/x64/handler-compiler-x64.cc

index 6224aca51e98b250178276199e85ef8ef76fd32b..399b96ff17a1f64b8bba962646d18b94d1aab958 100644

--- a/src/ic/x64/handler-compiler-x64.cc

+++ b/src/ic/x64/handler-compiler-x64.cc

@@ -694,8 +694,7 @@ void NamedLoadHandlerCompiler::GenerateLoadInterceptorWithFollowup(

!holder().is_identical_to(it->GetHolder<JSObject>());

bool must_preserve_receiver_reg =

!receiver().is(holder_reg) &&

- (it->property_kind() == LookupIterator::ACCESSOR ||

- must_perform_prototype_check);

+ (it->state() == LookupIterator::ACCESSOR || must_perform_prototype_check);

// Save necessary data before invoking an interceptor.

// Requires a frame to make GC aware of pushed pointers.

« no previous file with comments | « src/ic/mips64/handler-compiler-mips64.cc ('k') | src/ic/x87/handler-compiler-x87.cc » ('j') | no next file with comments »