Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 539903002: Move StructuredMachineAssembler into cctest suite. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move StructuredMachineAssembler into cctest suite. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23681

Patch Set 1 #

Patch Set 2 : Add a TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -1179 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
D src/compiler/simplified-node-factory.h View 1 chunk +0 lines, -128 lines 0 comments Download
D src/compiler/structured-machine-assembler.h View 1 chunk +0 lines, -299 lines 0 comments Download
D src/compiler/structured-machine-assembler.cc View 1 chunk +0 lines, -664 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/simplified-graph-builder.h View 3 chunks +96 lines, -25 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.cc View 3 chunks +52 lines, -41 lines 0 comments Download
A + test/cctest/compiler/structured-machine-assembler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/cctest/compiler/structured-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M test/cctest/compiler/test-structured-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
Please appreciate the following diff-stat for the "src" production code directory: 3 files changed, 1091 ...
6 years, 3 months ago (2014-09-04 09:15:21 UTC) #1
Benedikt Meurer
The amount of dead code is amazing.
6 years, 3 months ago (2014-09-04 09:17:47 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-09-04 09:18:54 UTC) #3
Michael Starzinger
6 years, 3 months ago (2014-09-04 10:24:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698