Issue 53823003: Add can-ignore-rect hint to clear call

Issue 53823003: Add can-ignore-rect hint to clear call (Closed)

Created:
7 years, 1 month ago by robertphillips

Modified:
7 years, 1 month ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

On deferred GPU architectures, full screen clears are free (if not even faster then partial clears). This CL exposes that behavior via the gpu capabilities and adds a flag to clear to allow the optimization.

Patch Set 1 #

Patch Set 2 : Turned on full clears for ARM and Imagination #

Patch Set 3 : cleaned up #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -17 lines)			Patch
M	include/gpu/GrContext.h	View	2	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/effects/SkBitmapAlphaThresholdShader.cpp	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkGpuBlurUtils.cpp	View	2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View		1 chunk	+1 line, -0 lines	2 comments	Download
M	src/gpu/GrGpu.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 2	3 chunks	+4 lines, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1	4 chunks	+7 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

GM images look the same before and after this change (at least when it is ...

7 years, 1 month ago (2013-10-31 19:05:34 UTC) #1

bsalomon

lgtm with a request for a comment in GrDrawTarget.h https://codereview.chromium.org/53823003/diff/50001/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (right): https://codereview.chromium.org/53823003/diff/50001/src/gpu/GrDrawTarget.h#newcode409 src/gpu/GrDrawTarget.h:409: ...

7 years, 1 month ago (2013-10-31 19:09:00 UTC) #2

robertphillips

7 years, 1 month ago (2013-10-31 21:45:18 UTC) #3

Message was sent while issue was closed.

committed as r12064. Will create new patch tomorrow to reorder arguments (color,
rect, bool, RT).

https://codereview.chromium.org/53823003/diff/50001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/53823003/diff/50001/src/gpu/GrDrawTarget.h#ne...
src/gpu/GrDrawTarget.h:409: */
On 2013/10/31 19:09:00, bsalomon wrote:
> doc?

Done.

Expand Messages | Collapse Messages