Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 536943002: Never skip access checks when looking up properties (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Never skip access checks in the lookup iterator BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23661

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -76 lines) Patch
M src/bootstrapper.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 6 chunks +30 lines, -21 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.h View 2 chunks +9 lines, -16 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +2 lines, -6 lines 0 comments Download
M src/objects.cc View 7 chunks +16 lines, -11 lines 0 comments Download
M src/runtime.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Toon Verwaest
PTAL
6 years, 3 months ago (2014-09-03 13:19:00 UTC) #2
Yang
On 2014/09/03 13:19:00, Toon Verwaest wrote: > PTAL lgtm.
6 years, 3 months ago (2014-09-03 13:32:15 UTC) #3
Toon Verwaest
6 years, 3 months ago (2014-09-03 14:06:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 23661 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698