src/factory.cc - Issue 536943002: Never skip access checks when looking up properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 536943002: Never skip access checks when looking up properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 85713ee23f26a8239be20f344d515c8965fe7b04..162cffc7ab69eea60149fab2973a3008883aff71 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2182,7 +2182,8 @@ Handle<JSFunction> Factory::CreateApiFunction(

if (prototype->IsTheHole()) {

#ifdef DEBUG

LookupIterator it(handle(JSObject::cast(result->prototype())),

- constructor_string(), LookupIterator::OWN_PROPERTY);

+ constructor_string(),

+ LookupIterator::OWN_SKIP_INTERCEPTOR);

MaybeHandle<Object> maybe_prop = Object::GetProperty(&it);

DCHECK(it.IsFound());

DCHECK(maybe_prop.ToHandleChecked().is_identical_to(result));

« no previous file with comments | « src/bootstrapper.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »