src/ic/ic.cc - Issue 536943002: Never skip access checks when looking up properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 536943002: Never skip access checks when looking up properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index a7a04518f64ee794205b2b1d59d49da5b8dead07..be935dff2983b05785353c2d3ac56e83b08b0bfe 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -283,7 +283,8 @@ bool IC::TryRemoveInvalidPrototypeDependentStub(Handle<Object> receiver,

if (receiver->IsGlobalObject()) {

Handle<GlobalObject> global = Handle<GlobalObject>::cast(receiver);

- LookupIterator it(global, name, LookupIterator::OWN_PROPERTY);

+ LookupIterator it(global, name, LookupIterator::OWN_SKIP_INTERCEPTOR);

+ if (it.state() == LookupIterator::ACCESS_CHECK) return false;

if (!it.IsFound() || !it.HasProperty()) return false;

Handle<PropertyCell> cell = it.GetPropertyCell();

return cell->type()->IsConstant();

« no previous file with comments | « src/hydrogen.cc ('k') | src/isolate.cc » ('j') | no next file with comments »