Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: src/lookup.h

Issue 536943002: Never skip access checks when looking up properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/lookup-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index 3d263e9634b529c75a1473c84ca17105f05148ee..6427aa944c90320830a34690eb38457a049e5d9d 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -16,21 +16,17 @@ class LookupIterator FINAL BASE_EMBEDDED {
public:
enum Configuration {
// Configuration bits.
- kAccessCheck = 1 << 0,
- kHidden = 1 << 1,
- kInterceptor = 1 << 2,
- kPrototypeChain = 1 << 3,
+ kHidden = 1 << 0,
+ kInterceptor = 1 << 1,
+ kPrototypeChain = 1 << 2,
// Convience combinations of bits.
- OWN_PROPERTY = 0,
- OWN_SKIP_INTERCEPTOR = kAccessCheck,
- OWN = kAccessCheck | kInterceptor,
- HIDDEN_PROPERTY = kHidden,
- HIDDEN_SKIP_INTERCEPTOR = kAccessCheck | kHidden,
- HIDDEN = kAccessCheck | kHidden | kInterceptor,
- PROTOTYPE_CHAIN_PROPERTY = kHidden | kPrototypeChain,
- PROTOTYPE_CHAIN_SKIP_INTERCEPTOR = kAccessCheck | kHidden | kPrototypeChain,
- PROTOTYPE_CHAIN = kAccessCheck | kHidden | kPrototypeChain | kInterceptor
+ OWN_SKIP_INTERCEPTOR = 0,
+ OWN = kInterceptor,
+ HIDDEN_SKIP_INTERCEPTOR = kHidden,
+ HIDDEN = kHidden | kInterceptor,
+ PROTOTYPE_CHAIN_SKIP_INTERCEPTOR = kHidden | kPrototypeChain,
+ PROTOTYPE_CHAIN = kHidden | kPrototypeChain | kInterceptor
};
enum State {
@@ -191,9 +187,6 @@ class LookupIterator FINAL BASE_EMBEDDED {
bool is_guaranteed_to_have_holder() const {
return !maybe_receiver_.is_null();
}
- bool check_access_check() const {
- return (configuration_ & kAccessCheck) != 0;
- }
bool check_hidden() const { return (configuration_ & kHidden) != 0; }
bool check_interceptor() const {
return !IsBootstrapping() && (configuration_ & kInterceptor) != 0;
« no previous file with comments | « src/isolate.cc ('k') | src/lookup-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698