Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 53373003: Remove display:run-in as per https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_tHSX… (Closed)

Created:
7 years, 1 month ago by ojan
Modified:
7 years, 1 month ago
CC:
blink-reviews, chromiumbugtracker_adobe.com, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Visibility:
Public.

Description

Remove display:run-in as per https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_tHSX0IYXhQ. The complexity does not justify the 0.008% of page views usage. If we decide it's worth implementing in the future, we can implement it in a more secure, maintainable way. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160992

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1305 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/editing/undo/undo-after-event-edited.html View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/css-generated-content/generated-runin.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/css/run-in-children.html View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/fast/forms/form-hides-table.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/lists/parent-box-not-box-crash.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/lists/parent-box-not-box-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/regions/region-element-display-change-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/region-element-display-restriction-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/script-tests/region-element-display-change.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/script-tests/region-element-display-restriction.js View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/runin/001.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/runin/001-expected.txt View 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/fast/runin/002.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/runin/002-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/crash-when-reparent-sibling.html View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/fast/runin/crash-when-reparent-sibling-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/runin/generated.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/runin/generated-content-crash.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/runin/generated-content-crash-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/generated-content-crash-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/runin/generated-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/runin/generated2.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/runin/generated2-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/generated3.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/runin/generated3-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/generated4.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/runin/generated4-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/input-text-runin.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/runin/input-text-runin-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/runin/insert-before-run-in.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/runin/insert-before-run-in-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/insert-before-run-in-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/move-run-in-original-position-crash.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/runin/move-run-in-original-position-crash-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/move-run-in-original-position-crash-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/nonblock-runin.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/runin/nonblock-runin-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/runin/progress-run-in-crash.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/progress-run-in-crash-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/runin/run-in-after-run-in.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/runin/run-in-after-run-in-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/run-in-after-run-in-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/run-in-layer-not-removed-crash.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/runin/run-in-layer-not-removed-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/runin/run-in-parent-add-child.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/runin/run-in-parent-add-child-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/run-in-parent-add-child-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/run-in-parent-block-child-add.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/runin/run-in-parent-block-child-add-and-intrude.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/runin/run-in-parent-block-child-add-and-intrude-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/run-in-parent-block-child-add-and-intrude-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/runin/run-in-parent-block-child-add-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/run-in-parent-block-child-add-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/runin/runin-between-list-marker-and-before-content.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/runin/runin-continuations-crash.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/runin/runin-continuations-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/runin/runin-div-before-child.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/runin/runin-div-before-child-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/runin-div-before-child-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/runin/runin-generated-before-content.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/runin/runin-generated-before-content-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/runin/runin-into-div-with-float-child.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/runin/runin-into-div-with-float-child-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/runin-into-div-with-float-child-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/runin/runin-not-go-into-float.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/runin/runin-not-go-into-float-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/runin-not-go-into-float-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/runin/runin-reparent-crash.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/runin/runin-reparent-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/runin/runin-table-before-child.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/runin/runin-table-before-child-expected.png View Binary file 0 comments Download
D LayoutTests/fast/runin/runin-table-before-child-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/runin/select-runin.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/runin/select-runin-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/runin/textarea-runin.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/runin/textarea-runin-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/table/form-with-table-style.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/form-hides-table-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/table/form-with-table-style-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/form-hides-table-expected.txt View 11 chunks +15 lines, -24 lines 0 comments Download
M LayoutTests/platform/win/fast/table/form-with-table-style-expected.txt View 1 chunk +11 lines, -15 lines 0 comments Download
M LayoutTests/platform/win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 8 chunks +2 lines, -169 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderListBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderMarquee.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderMenuList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 3 chunks +1 line, -9 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/rendering/RenderProgress.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderProgress.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderSlider.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderSlider.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderTextControl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTextControl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ojan
7 years, 1 month ago (2013-10-30 21:20:58 UTC) #1
ojan
https://codereview.chromium.org/53373003/diff/1/Source/core/rendering/RenderInline.cpp File Source/core/rendering/RenderInline.cpp (right): https://codereview.chromium.org/53373003/diff/1/Source/core/rendering/RenderInline.cpp#newcode129 Source/core/rendering/RenderInline.cpp:129: setInline(true); A bit unsure about this. I'll try removing ...
7 years, 1 month ago (2013-10-30 21:23:26 UTC) #2
eseidel
lgtm Wow. I suspect there is more dead code here...
7 years, 1 month ago (2013-10-30 21:25:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/53373003/1
7 years, 1 month ago (2013-10-30 21:26:26 UTC) #4
ojan
This editing/undo/undo-after-event-edited.html timeout on the trybots is actually from this patch. :(
7 years, 1 month ago (2013-10-30 22:18:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/53373003/190001
7 years, 1 month ago (2013-10-30 22:37:24 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 00:32:49 UTC) #7
Message was sent while issue was closed.
Change committed as 160992

Powered by Google App Engine
This is Rietveld 408576698