Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: Source/core/rendering/RenderSlider.cpp

Issue 53373003: Remove display:run-in as per https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_tHSX… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix test Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderSlider.h ('k') | Source/core/rendering/RenderTextControl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 26 matching lines...) Expand all
37 : RenderFlexibleBox(element) 37 : RenderFlexibleBox(element)
38 { 38 {
39 // We assume RenderSlider works only with <input type=range>. 39 // We assume RenderSlider works only with <input type=range>.
40 ASSERT(element->isRangeControl()); 40 ASSERT(element->isRangeControl());
41 } 41 }
42 42
43 RenderSlider::~RenderSlider() 43 RenderSlider::~RenderSlider()
44 { 44 {
45 } 45 }
46 46
47 bool RenderSlider::canBeReplacedWithInlineRunIn() const
48 {
49 return false;
50 }
51
52 int RenderSlider::baselinePosition(FontBaseline, bool /*firstLine*/, LineDirecti onMode, LinePositionMode linePositionMode) const 47 int RenderSlider::baselinePosition(FontBaseline, bool /*firstLine*/, LineDirecti onMode, LinePositionMode linePositionMode) const
53 { 48 {
54 ASSERT(linePositionMode == PositionOnContainingLine); 49 ASSERT(linePositionMode == PositionOnContainingLine);
55 // FIXME: Patch this function for writing-mode. 50 // FIXME: Patch this function for writing-mode.
56 return height() + marginTop(); 51 return height() + marginTop();
57 } 52 }
58 53
59 void RenderSlider::computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, La youtUnit& maxLogicalWidth) const 54 void RenderSlider::computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, La youtUnit& maxLogicalWidth) const
60 { 55 {
61 maxLogicalWidth = defaultTrackLength * style()->effectiveZoom(); 56 maxLogicalWidth = defaultTrackLength * style()->effectiveZoom();
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 100
106 RenderFlexibleBox::layout(); 101 RenderFlexibleBox::layout();
107 } 102 }
108 103
109 bool RenderSlider::inDragMode() const 104 bool RenderSlider::inDragMode() const
110 { 105 {
111 return sliderThumbElement()->active(); 106 return sliderThumbElement()->active();
112 } 107 }
113 108
114 } // namespace WebCore 109 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderSlider.h ('k') | Source/core/rendering/RenderTextControl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698