Issue 531733004: Revert of Revert of Add support for codepen to form_based_credentials_background (patchset #9 of h…

Issue 531733004: Revert of Revert of Add support for codepen to form_based_credentials_background (patchset #9 of h… (Closed)

Created:
6 years, 3 months ago by sullivan

Modified:
6 years, 3 months ago

Reviewers:
tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org, dtu

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Revert of Add support for codepen to form_based_credentials_background (patchset #9 of https://codereview.chromium.org/485743002/) Reason for revert: I believe the flakiness may have been fixed by https://codereview.chromium.org/520683002 BUG= Committed: https://crrev.com/dab69c8fc34fcd6143e4ab82193b207e38c1207c Cr-Commit-Position: refs/heads/master@{#292950}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -60 lines)			Patch
M	tools/perf/page_sets/data/credentials.json.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tools/telemetry/telemetry/core/backends/codepen_credentials_backend.py	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A +	tools/telemetry/telemetry/core/backends/codepen_credentials_backend_unittest.py	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/facebook_credentials_backend_unittest.py	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py	View	5 chunks	+39 lines, -34 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py	View	2 chunks	+11 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/google_credentials_backend.py	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/browser_credentials.py	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/browser_credentials_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

sullivan

Let me know I should change the review issue id to https://codereview.chromium.org/485743002/ I added some ...

6 years, 3 months ago (2014-09-02 15:55:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/531733004/1

6 years, 3 months ago (2014-09-02 16:19:46 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 88f5dc0538f682fe9451a10c1e86637aaa59428b

6 years, 3 months ago (2014-09-02 17:10:01 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:19:13 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dab69c8fc34fcd6143e4ab82193b207e38c1207c
Cr-Commit-Position: refs/heads/master@{#292950}