Chromium Code Reviews

Unified Diff: tools/telemetry/telemetry/core/browser_credentials.py

Issue 531733004: Revert of Revert of Add support for codepen to form_based_credentials_background (patchset #9 of h… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: tools/telemetry/telemetry/core/browser_credentials.py
diff --git a/tools/telemetry/telemetry/core/browser_credentials.py b/tools/telemetry/telemetry/core/browser_credentials.py
index d78ced98568ed79a18274462f88c0300532c5948..b44e47b07a1157ead2e2089b3957370bb160328b 100644
--- a/tools/telemetry/telemetry/core/browser_credentials.py
+++ b/tools/telemetry/telemetry/core/browser_credentials.py
@@ -7,8 +7,10 @@ import logging
import os
from telemetry.core import util
+from telemetry.core.backends import codepen_credentials_backend
from telemetry.core.backends import facebook_credentials_backend
from telemetry.core.backends import google_credentials_backend
+from telemetry.page.actions import action_runner
from telemetry.unittest import options_for_unittests
@@ -24,6 +26,7 @@ class BrowserCredentials(object):
if backends is None:
backends = [
+ codepen_credentials_backend.CodePenCredentialsBackend(),
facebook_credentials_backend.FacebookCredentialsBackend(),
google_credentials_backend.GoogleCredentialsBackend()]
@@ -55,8 +58,9 @@ class BrowserCredentials(object):
'Unrecognized credentials type: %s', credentials_type)
if credentials_type not in self._credentials:
return False
+ runner = action_runner.ActionRunner(tab)
return self._backends[credentials_type].LoginNeeded(
- tab, self._credentials[credentials_type])
+ tab, runner, self._credentials[credentials_type])
def LoginNoLongerNeeded(self, tab, credentials_type):
assert credentials_type in self._backends

Powered by Google App Engine