tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py - Issue 531733004: Revert of Revert of Add support for codepen to form_based_credentials_background (patchset #9 of h…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py

Issue 531733004: Revert of Revert of Add support for codepen to form_based_credentials_background (patchset #9 of h… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/codepen_credentials_backend_unittest.py ('k') | tools/telemetry/telemetry/core/backends/facebook_credentials_backend_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py b/tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py

index 2b66f9dc1063fbd96616f4d00da097672ebdccc7..b391e9f91992baf8936e32df627a0113aa00d016 100644

--- a/tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py

+++ b/tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py

@@ -7,10 +7,12 @@ from telemetry.core.backends import form_based_credentials_backend

class FacebookCredentialsBackend(

form_based_credentials_backend.FormBasedCredentialsBackend):

- def IsAlreadyLoggedIn(self, tab):

- return tab.EvaluateJavaScript(

- 'document.getElementById("fbNotificationsList")!== null || '

- 'document.getElementById("m_home_notice")!== null')

+ @property

+ def logged_in_javascript(self):

+ """Evaluates to true iff already logged in."""

+ return ('document.getElementById("fbNotificationsList")!== null || '

+ 'document.getElementById("m_home_notice")!== null')

@property

def credentials_type(self):