Chromium Code Reviews

Issue 520683002: Re-reenable memory tests. Fixed sign-in issue. (Closed)

Created:
6 years, 3 months ago by Victor Starodub
Modified:
6 years, 3 months ago
Reviewers:
marja
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-reenable memory tests. Fixed sign-in issue. Added missing recording. BUG=370977 Committed: https://crrev.com/435610515900bb7875eeea87366ff6cfd8d91634 Cr-Commit-Position: refs/heads/master@{#292639}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+14 lines, -10 lines)
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -1 line 0 comments
M tools/perf/page_sets/data/mobile_memory.json View 1 chunk +5 lines, -5 lines 0 comments
A tools/perf/page_sets/data/mobile_memory_018.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments
M tools/telemetry/telemetry/core/backends/google_credentials_backend.py View 1 chunk +5 lines, -1 line 0 comments
M tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py View 1 chunk +3 lines, -3 lines 0 comments

Messages

Total messages: 9 (0 generated)
Victor Starodub
starodub@google.com changed reviewers: + marja@chromium.org
6 years, 3 months ago (2014-08-29 13:31:31 UTC) #1
Victor Starodub
6 years, 3 months ago (2014-08-29 13:31:31 UTC) #2
marja
Is this exactly the same as https://codereview.chromium.org/491863003 or what's the difference?
6 years, 3 months ago (2014-08-29 13:41:33 UTC) #3
Victor Starodub
On 2014/08/29 13:41:33, marja wrote: > Is this exactly the same as https://codereview.chromium.org/491863003 or what's ...
6 years, 3 months ago (2014-08-29 13:47:19 UTC) #4
marja
Rubberstamp lgtm, since skyostil@ has already reviewed an equivalent CL. If its easier for you, ...
6 years, 3 months ago (2014-08-29 13:56:19 UTC) #5
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 3 months ago (2014-08-29 13:58:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/520683002/1
6 years, 3 months ago (2014-08-29 13:59:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0d7bf70f4683128a009370a2161a0d4b23fe0507
6 years, 3 months ago (2014-08-29 15:29:30 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:08:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/435610515900bb7875eeea87366ff6cfd8d91634
Cr-Commit-Position: refs/heads/master@{#292639}

Powered by Google App Engine