Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 528993002: First step to cleanup the power-of-2 mess. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

First step to cleanup the power-of-2 mess. TEST=base-unittests,cctest,mjsunit R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23617

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : clang-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -141 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/allocation.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +1 line, -10 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 3 chunks +13 lines, -1 line 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 5 chunks +5 lines, -4 lines 0 comments Download
M src/base/bits.h View 1 chunk +31 lines, -0 lines 0 comments Download
A src/base/bits.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/base/bits-unittest.cc View 1 2 5 chunks +64 lines, -5 lines 0 comments Download
M src/base/macros.h View 3 chunks +1 line, -43 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/machine-type.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/representation-change.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/conversions-inl.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/factory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/gdb-jit.cc View 1 2 3 chunks +5 lines, -9 lines 0 comments Download
M src/hashmap.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/heap/spaces.h View 4 chunks +4 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 5 chunks +5 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/ic/stub-cache.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/utils.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-02 13:21:08 UTC) #1
Sven Panne
LGTM, mostly rubberstamped
6 years, 3 months ago (2014-09-02 13:28:30 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-02 13:37:10 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 23617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698