src/arm64/macro-assembler-arm64-inl.h - Issue 528993002: First step to cleanup the power-of-2 mess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/macro-assembler-arm64-inl.h

Issue 528993002: First step to cleanup the power-of-2 mess. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: clang-format Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/macro-assembler-arm64-inl.h

diff --git a/src/arm64/macro-assembler-arm64-inl.h b/src/arm64/macro-assembler-arm64-inl.h

index f7c724842ac55ffb1584d4770962fd0996306c3e..23767e48b371c78d5cbdd472c8f1cc5cbe5d35ba 100644

--- a/src/arm64/macro-assembler-arm64-inl.h

+++ b/src/arm64/macro-assembler-arm64-inl.h

@@ -13,6 +13,7 @@

#include "src/arm64/assembler-arm64.h"

#include "src/arm64/instrument-arm64.h"

#include "src/arm64/macro-assembler-arm64.h"

+#include "src/base/bits.h"

namespace v8 {

@@ -1520,7 +1521,7 @@ void MacroAssembler::Claim(uint64_t count, uint64_t unit_size) {

void MacroAssembler::Claim(const Register& count, uint64_t unit_size) {

if (unit_size == 0) return;

- DCHECK(IsPowerOf2(unit_size));

+ DCHECK(base::bits::IsPowerOfTwo64(unit_size));

const int shift = CountTrailingZeros(unit_size, kXRegSizeInBits);

const Operand size(count, LSL, shift);

@@ -1538,7 +1539,7 @@ void MacroAssembler::Claim(const Register& count, uint64_t unit_size) {

void MacroAssembler::ClaimBySMI(const Register& count_smi, uint64_t unit_size) {

- DCHECK(unit_size == 0 || IsPowerOf2(unit_size));

+ DCHECK(unit_size == 0 || base::bits::IsPowerOfTwo64(unit_size));

const int shift = CountTrailingZeros(unit_size, kXRegSizeInBits) - kSmiShift;

const Operand size(count_smi,

(shift >= 0) ? (LSL) : (LSR),

@@ -1578,7 +1579,7 @@ void MacroAssembler::Drop(uint64_t count, uint64_t unit_size) {

void MacroAssembler::Drop(const Register& count, uint64_t unit_size) {