src/frames.cc - Issue 528993002: First step to cleanup the power-of-2 mess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 528993002: First step to cleanup the power-of-2 mess. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: clang-format Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index a4e77ff5561aeed691c5a7d055770cb91fb01d0b..01c0a4960ec66036abdc6754ce4cbbeeec80eba8 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -1501,7 +1501,7 @@ Code* InnerPointerToCodeCache::GcSafeFindCodeForInnerPointer(

InnerPointerToCodeCache::InnerPointerToCodeCacheEntry*

InnerPointerToCodeCache::GetCacheEntry(Address inner_pointer) {

isolate_->counters()->pc_to_code()->Increment();

- DCHECK(IsPowerOf2(kInnerPointerToCodeCacheSize));

+ DCHECK(base::bits::IsPowerOfTwo32(kInnerPointerToCodeCacheSize));

uint32_t hash = ComputeIntegerHash(

static_cast<uint32_t>(reinterpret_cast<uintptr_t>(inner_pointer)),

v8::internal::kZeroHashSeed);

« no previous file with comments | « src/factory.cc ('k') | src/gdb-jit.cc » ('j') | no next file with comments »