Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 52593009: Use TextTrackMode and TextTrackKind enums in TextTrack IDL (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, philipj_slow, dglazkov+blink, Inactive, vcarbune.chromium, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use TextTrackMode and TextTrackKind enums in TextTrack IDL The generated code (modeAttributeSetter in V8TextTrack.cpp) now checks that the string is one of the three allowed values, so we can just assert it internally. Also fiddle a bit with the IDL to make it match the spec order. BUG=313602 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161055

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M Source/core/html/track/TextTrack.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrack.idl View 1 chunk +7 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
7 years, 1 month ago (2013-10-31 08:58:54 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/52593009/diff/1/Source/core/html/track/TextTrack.idl File Source/core/html/track/TextTrack.idl (right): https://codereview.chromium.org/52593009/diff/1/Source/core/html/track/TextTrack.idl#newcode44 Source/core/html/track/TextTrack.idl:44: attribute EventHandler oncuechange; why did you move the ...
7 years, 1 month ago (2013-10-31 10:32:10 UTC) #2
philipj_slow
https://codereview.chromium.org/52593009/diff/1/Source/core/html/track/TextTrack.idl File Source/core/html/track/TextTrack.idl (right): https://codereview.chromium.org/52593009/diff/1/Source/core/html/track/TextTrack.idl#newcode44 Source/core/html/track/TextTrack.idl:44: attribute EventHandler oncuechange; On 2013/10/31 10:32:10, jochen wrote: > ...
7 years, 1 month ago (2013-10-31 10:40:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52593009/1
7 years, 1 month ago (2013-10-31 10:47:54 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 12:58:56 UTC) #5
Message was sent while issue was closed.
Change committed as 161055

Powered by Google App Engine
This is Rietveld 408576698