 Chromium Code Reviews
 Chromium Code Reviews Issue 52593009:
  Use TextTrackMode and TextTrackKind enums in TextTrack IDL  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 52593009:
  Use TextTrackMode and TextTrackKind enums in TextTrack IDL  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/html/track/TextTrack.idl | 
| diff --git a/Source/core/html/track/TextTrack.idl b/Source/core/html/track/TextTrack.idl | 
| index 008709a8b70f9561f612d2e00199df8098107fcd..f11c4bd7a4d59002b38f083e30b4a53167114905 100644 | 
| --- a/Source/core/html/track/TextTrack.idl | 
| +++ b/Source/core/html/track/TextTrack.idl | 
| @@ -23,22 +23,26 @@ | 
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 
| */ | 
| +enum TextTrackMode { "disabled", "hidden", "showing" }; | 
| +enum TextTrackKind { "subtitles", "captions", "descriptions", "chapters", "metadata" }; | 
| + | 
| [ | 
| RuntimeEnabled=VideoTrack | 
| ] interface TextTrack : EventTarget { | 
| - readonly attribute DOMString kind; | 
| + readonly attribute TextTrackKind kind; | 
| readonly attribute DOMString label; | 
| readonly attribute DOMString language; | 
| - attribute DOMString mode; | 
| + attribute TextTrackMode mode; | 
| readonly attribute TextTrackCueList cues; | 
| readonly attribute TextTrackCueList activeCues; | 
| - attribute EventHandler oncuechange; | 
| void addCue(TextTrackCue cue); | 
| [RaisesException] void removeCue(TextTrackCue cue); | 
| + attribute EventHandler oncuechange; | 
| 
jochen (gone - plz use gerrit)
2013/10/31 10:32:10
why did you move the attribute down here?
 
philipj_slow
2013/10/31 10:40:13
To match the order of the spec:
http://www.whatwg.
 | 
| + | 
| [RuntimeEnabled=WebVTTRegions] readonly attribute TextTrackRegionList regions; | 
| [RuntimeEnabled=WebVTTRegions] void addRegion(TextTrackRegion region); | 
| [RaisesException, RuntimeEnabled=WebVTTRegions] void removeRegion(TextTrackRegion region); |