Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: Source/core/html/track/TextTrack.cpp

Issue 52593009: Use TextTrackMode and TextTrackKind enums in TextTrack IDL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/track/TextTrack.idl » ('j') | Source/core/html/track/TextTrack.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrack.cpp
diff --git a/Source/core/html/track/TextTrack.cpp b/Source/core/html/track/TextTrack.cpp
index bf17e6cda739657f7c0bbc0d98c1c55df3f2d681..12626dea6144e2789a3b534a6fb01750b5a2d700 100644
--- a/Source/core/html/track/TextTrack.cpp
+++ b/Source/core/html/track/TextTrack.cpp
@@ -162,11 +162,10 @@ void TextTrack::setKind(const AtomicString& kind)
void TextTrack::setMode(const AtomicString& mode)
{
+ ASSERT(mode == disabledKeyword() || mode == hiddenKeyword() || mode == showingKeyword());
+
// On setting, if the new value isn't equal to what the attribute would currently
// return, the new value must be processed as follows ...
- if (mode != disabledKeyword() && mode != hiddenKeyword() && mode != showingKeyword())
- return;
-
if (m_mode == mode)
return;
« no previous file with comments | « no previous file | Source/core/html/track/TextTrack.idl » ('j') | Source/core/html/track/TextTrack.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698