Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 524623005: Add testonly flag to GN (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/85423a03bb323c0660c402d3a1f62169ca696dd8 Cr-Commit-Position: refs/heads/master@{#292976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -92 lines) Patch
M tools/gn/builder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gn/command_gen.cc View 2 chunks +4 lines, -23 lines 0 comments Download
M tools/gn/config_values_extractors_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/gn/item.h View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/gn/item.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/label_ptr.h View 1 chunk +5 lines, -1 line 0 comments Download
M tools/gn/ninja_action_target_writer_unittest.cc View 11 chunks +17 lines, -8 lines 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 9 chunks +12 lines, -6 lines 0 comments Download
M tools/gn/ninja_copy_target_writer_unittest.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M tools/gn/ninja_target_writer_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M tools/gn/substitution_writer_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M tools/gn/target.h View 5 chunks +11 lines, -1 line 0 comments Download
M tools/gn/target.cc View 5 chunks +95 lines, -13 lines 0 comments Download
M tools/gn/target_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/target_generator.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M tools/gn/target_unittest.cc View 16 chunks +132 lines, -23 lines 0 comments Download
M tools/gn/variables.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
6 years, 3 months ago (2014-08-29 19:32:54 UTC) #2
Alpha Left Google
LGTM.
6 years, 3 months ago (2014-09-02 18:22:53 UTC) #3
brettw
Committed patchset #1 (id:1) to pending queue manually as 2401eeb (presubmit successful).
6 years, 3 months ago (2014-09-02 19:41:11 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:00 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85423a03bb323c0660c402d3a1f62169ca696dd8
Cr-Commit-Position: refs/heads/master@{#292976}

Powered by Google App Engine
This is Rietveld 408576698