tools/gn/item.h - Issue 524623005: Add testonly flag to GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/item.h

Issue 524623005: Add testonly flag to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/item.h

diff --git a/tools/gn/item.h b/tools/gn/item.h

index 4e582bfca305de7d569f240209050a6aca1e97fc..069c3edc55848419f636171ac08215b23eb12e45 100644

--- a/tools/gn/item.h

+++ b/tools/gn/item.h

@@ -48,8 +48,9 @@ class Item {

std::string GetItemTypeName() const;

// Called when this item is resolved, meaning it and all of its dependents

- // have no unresolved deps.

- virtual void OnResolved() {}

+ // have no unresolved deps. Returns true on success. Sets the error and

+ // returns false on failure.

+ virtual bool OnResolved(Err* err);

private:

const Settings* settings_;

« no previous file with comments | « tools/gn/config_values_extractors_unittest.cc ('k') | tools/gn/item.cc » ('j') | no next file with comments »