tools/gn/builder.cc - Issue 524623005: Add testonly flag to GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/builder.cc

Issue 524623005: Add testonly flag to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/builder.cc

diff --git a/tools/gn/builder.cc b/tools/gn/builder.cc

index dccc095a949c6658a8211110fa61c1ed2100f108..65c5f601e967366b74d1a39d38830a25d7781b8b 100644

--- a/tools/gn/builder.cc

+++ b/tools/gn/builder.cc

@@ -418,7 +418,9 @@ bool Builder::ResolveItem(BuilderRecord* record, Err* err) {

}

record->set_resolved(true);

- record->item()->OnResolved();

+ if (!record->item()->OnResolved(err))

+ return false;

if (!resolved_callback_.is_null())

resolved_callback_.Run(record);

« no previous file with comments | « no previous file | tools/gn/command_gen.cc » ('j') | no next file with comments »