Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/gn/command_gen.cc

Issue 524623005: Add testonly flag to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/builder.cc ('k') | tools/gn/config_values_extractors_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gen.cc
diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index 0df121a954f0d1d5a73f121427ef185bda9cded7..5e6e724852af054f0be1f11ef6d0ee8e75a1249a 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -25,20 +25,9 @@ const char kSwitchQuiet[] = "q";
const char kSwitchCheck[] = "check";
-void BackgroundDoWrite(const Target* target,
- const std::vector<const Item*>& deps_for_visibility) {
- // Validate visibility.
- Err err;
- for (size_t i = 0; i < deps_for_visibility.size(); i++) {
- if (!Visibility::CheckItemVisibility(target, deps_for_visibility[i],
- &err)) {
- g_scheduler->FailWithError(err);
- break; // Don't return early since we need DecrementWorkCount below.
- }
- }
-
- if (!err.has_error())
- NinjaTargetWriter::RunAndWriteFile(target);
+// Called on worker thread to write the ninja file.
+void BackgroundDoWrite(const Target* target) {
+ NinjaTargetWriter::RunAndWriteFile(target);
g_scheduler->DecrementWorkCount();
}
@@ -51,16 +40,8 @@ void ItemResolvedCallback(base::subtle::Atomic32* write_counter,
const Item* item = record->item();
const Target* target = item->AsTarget();
if (target) {
- // Collect all dependencies.
- std::vector<const Item*> deps;
- for (BuilderRecord::BuilderRecordSet::const_iterator iter =
- record->all_deps().begin();
- iter != record->all_deps().end();
- ++iter)
- deps.push_back((*iter)->item());
-
g_scheduler->IncrementWorkCount();
- g_scheduler->ScheduleWork(base::Bind(&BackgroundDoWrite, target, deps));
+ g_scheduler->ScheduleWork(base::Bind(&BackgroundDoWrite, target));
}
}
« no previous file with comments | « tools/gn/builder.cc ('k') | tools/gn/config_values_extractors_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698