Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 523743005: Fix HidService lifetime issues (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix HidService lifetime issues This reverts HidService to being a singleton instance for now. BUG=401234 TBR=rpaquay Committed: https://crrev.com/1a51b92b7038b82a90c1a1944104eaf8c51a9e1c Cr-Commit-Position: refs/heads/master@{#293464}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : where did that stupid line come from #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -110 lines) Patch
M chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_device_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_device_client.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M device/core/device_client.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M device/core/device_client.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M device/hid/hid_connection_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/hid/hid_service.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M device/hid/hid_service.cc View 1 2 chunks +37 lines, -7 lines 0 comments Download
M device/hid/hid_service_linux.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M device/hid/hid_service_linux.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M device/hid/hid_service_unittest.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/extensions_api_client.h View 2 chunks +0 lines, -7 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/browser/api/hid/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.cc View 1 5 chunks +6 lines, -4 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/shell/browser/api/shell_extensions_api_client.h View 1 chunk +0 lines, -28 lines 0 comments Download
D extensions/shell/browser/api/shell_extensions_api_client.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M extensions/shell/browser/shell_device_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/shell_device_client.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Ken Rockot(use gerrit already)
ptal!
6 years, 3 months ago (2014-08-29 21:24:07 UTC) #2
Reilly Grant (use Gerrit)
Please move extensions::ExtensionsAPIClient::GetHidService to device::DeviceClient::GetHidService.
6 years, 3 months ago (2014-08-29 23:05:47 UTC) #3
Ken Rockot(use gerrit already)
OK. I think we're good, but I could use an OWNERS stamp.
6 years, 3 months ago (2014-09-05 00:04:02 UTC) #6
Reilly Grant (use Gerrit)
lgtm with some nits https://codereview.chromium.org/523743005/diff/60001/device/core/device_client.cc File device/core/device_client.cc (right): https://codereview.chromium.org/523743005/diff/60001/device/core/device_client.cc#newcode39 device/core/device_client.cc:39: // This should never be ...
6 years, 3 months ago (2014-09-05 00:12:41 UTC) #7
Ken Rockot(use gerrit already)
https://codereview.chromium.org/523743005/diff/60001/device/core/device_client.cc File device/core/device_client.cc (right): https://codereview.chromium.org/523743005/diff/60001/device/core/device_client.cc#newcode39 device/core/device_client.cc:39: // This should never be called by clients which ...
6 years, 3 months ago (2014-09-05 00:15:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/523743005/80001
6 years, 3 months ago (2014-09-05 00:21:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/523743005/100001
6 years, 3 months ago (2014-09-05 02:40:50 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:100001) as f65a364961f77e2a7aeb7161dc72f6da30654da4
6 years, 3 months ago (2014-09-05 08:04:13 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:38 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/1a51b92b7038b82a90c1a1944104eaf8c51a9e1c
Cr-Commit-Position: refs/heads/master@{#293464}

Powered by Google App Engine
This is Rietveld 408576698