Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: extensions/browser/api/hid/hid_api.cc

Issue 523743005: Fix HidService lifetime issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: where did that stupid line come from Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/api/hid/DEPS ('k') | extensions/browser/api/hid/hid_device_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/hid/hid_api.h" 5 #include "extensions/browser/api/hid/hid_api.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "device/core/device_client.h"
10 #include "device/hid/hid_connection.h" 11 #include "device/hid/hid_connection.h"
11 #include "device/hid/hid_device_filter.h" 12 #include "device/hid/hid_device_filter.h"
12 #include "device/hid/hid_device_info.h" 13 #include "device/hid/hid_device_info.h"
13 #include "device/hid/hid_service.h" 14 #include "device/hid/hid_service.h"
14 #include "extensions/browser/api/api_resource_manager.h" 15 #include "extensions/browser/api/api_resource_manager.h"
15 #include "extensions/browser/api/extensions_api_client.h"
16 #include "extensions/common/api/hid.h" 16 #include "extensions/common/api/hid.h"
17 #include "net/base/io_buffer.h" 17 #include "net/base/io_buffer.h"
18 18
19 namespace hid = extensions::core_api::hid; 19 namespace hid = extensions::core_api::hid;
20 20
21 using device::HidConnection; 21 using device::HidConnection;
22 using device::HidDeviceFilter; 22 using device::HidDeviceFilter;
23 using device::HidDeviceInfo; 23 using device::HidDeviceInfo;
24 using device::HidService; 24 using device::HidService;
25 25
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 CompleteWithError(kErrorInvalidDeviceId); 136 CompleteWithError(kErrorInvalidDeviceId);
137 return; 137 return;
138 } 138 }
139 139
140 if (!device_manager_->HasPermission(extension(), device_info)) { 140 if (!device_manager_->HasPermission(extension(), device_info)) {
141 LOG(WARNING) << "Insufficient permissions to access device."; 141 LOG(WARNING) << "Insufficient permissions to access device.";
142 CompleteWithError(kErrorPermissionDenied); 142 CompleteWithError(kErrorPermissionDenied);
143 return; 143 return;
144 } 144 }
145 145
146 HidService* hid_service = ExtensionsAPIClient::Get()->GetHidService(); 146 HidService* hid_service = device::DeviceClient::Get()->GetHidService();
147 DCHECK(hid_service); 147 DCHECK(hid_service);
148 scoped_refptr<HidConnection> connection = 148 scoped_refptr<HidConnection> connection =
149 hid_service->Connect(device_info.device_id); 149 hid_service->Connect(device_info.device_id);
150 if (!connection.get()) { 150 if (!connection.get()) {
151 CompleteWithError(kErrorFailedToOpenDevice); 151 CompleteWithError(kErrorFailedToOpenDevice);
152 return; 152 return;
153 } 153 }
154 int connection_id = connection_manager_->Add( 154 int connection_id = connection_manager_->Add(
155 new HidConnectionResource(extension_->id(), connection)); 155 new HidConnectionResource(extension_->id(), connection));
156 SetResult(PopulateHidConnection(connection_id, connection)); 156 SetResult(PopulateHidConnection(connection_id, connection));
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 327
328 void HidSendFeatureReportFunction::OnFinished(bool success) { 328 void HidSendFeatureReportFunction::OnFinished(bool success) {
329 if (!success) { 329 if (!success) {
330 CompleteWithError(kErrorTransfer); 330 CompleteWithError(kErrorTransfer);
331 return; 331 return;
332 } 332 }
333 AsyncWorkCompleted(); 333 AsyncWorkCompleted();
334 } 334 }
335 335
336 } // namespace extensions 336 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/api/hid/DEPS ('k') | extensions/browser/api/hid/hid_device_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698