Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: extensions/browser/api/extensions_api_client.cc

Issue 523743005: Fix HidService lifetime issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: where did that stupid line come from Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/api/extensions_api_client.h ('k') | extensions/browser/api/hid/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/extensions_api_client.h" 5 #include "extensions/browser/api/extensions_api_client.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace extensions { 9 namespace extensions {
10 class AppViewGuestDelegate; 10 class AppViewGuestDelegate;
(...skipping 12 matching lines...) Expand all
23 void ExtensionsAPIClient::AddAdditionalValueStoreCaches( 23 void ExtensionsAPIClient::AddAdditionalValueStoreCaches(
24 content::BrowserContext* context, 24 content::BrowserContext* context,
25 const scoped_refptr<SettingsStorageFactory>& factory, 25 const scoped_refptr<SettingsStorageFactory>& factory,
26 const scoped_refptr<ObserverListThreadSafe<SettingsObserver> >& observers, 26 const scoped_refptr<ObserverListThreadSafe<SettingsObserver> >& observers,
27 std::map<settings_namespace::Namespace, ValueStoreCache*>* caches) {} 27 std::map<settings_namespace::Namespace, ValueStoreCache*>* caches) {}
28 28
29 AppViewGuestDelegate* ExtensionsAPIClient::CreateAppViewGuestDelegate() const { 29 AppViewGuestDelegate* ExtensionsAPIClient::CreateAppViewGuestDelegate() const {
30 return NULL; 30 return NULL;
31 } 31 }
32 32
33 device::HidService* ExtensionsAPIClient::GetHidService() {
34 // This should never be called by clients which don't support the HID API.
35 NOTIMPLEMENTED();
36 return NULL;
37 }
38
39 WebViewGuestDelegate* ExtensionsAPIClient::CreateWebViewGuestDelegate( 33 WebViewGuestDelegate* ExtensionsAPIClient::CreateWebViewGuestDelegate(
40 WebViewGuest* web_view_guest) const { 34 WebViewGuest* web_view_guest) const {
41 return NULL; 35 return NULL;
42 } 36 }
43 37
44 WebViewPermissionHelperDelegate* ExtensionsAPIClient:: 38 WebViewPermissionHelperDelegate* ExtensionsAPIClient::
45 CreateWebViewPermissionHelperDelegate( 39 CreateWebViewPermissionHelperDelegate(
46 WebViewPermissionHelper* web_view_permission_helper) const { 40 WebViewPermissionHelper* web_view_permission_helper) const {
47 return NULL; 41 return NULL;
48 } 42 }
49 43
50 } // namespace extensions 44 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/api/extensions_api_client.h ('k') | extensions/browser/api/hid/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698