chrome/browser/extensions/api/chrome_extensions_api_client.h - Issue 523743005: Fix HidService lifetime issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/chrome_extensions_api_client.h

Issue 523743005: Fix HidService lifetime issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: where did that stupid line come from Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/chrome_extensions_api_client.h

diff --git a/chrome/browser/extensions/api/chrome_extensions_api_client.h b/chrome/browser/extensions/api/chrome_extensions_api_client.h

index 881a627ac6846368341a97476052d16dbbe37ca4..e7bc28c361c8789d352c158154a1f80bee4b6031 100644

--- a/chrome/browser/extensions/api/chrome_extensions_api_client.h

+++ b/chrome/browser/extensions/api/chrome_extensions_api_client.h

@@ -6,7 +6,6 @@

#define CHROME_BROWSER_EXTENSIONS_API_CHROME_EXTENSIONS_API_CLIENT_H_

#include "base/compiler_specific.h"

-#include "base/memory/scoped_ptr.h"

#include "extensions/browser/api/extensions_api_client.h"

namespace extensions {

@@ -30,12 +29,9 @@ class ChromeExtensionsAPIClient : public ExtensionsAPIClient {

virtual WebViewPermissionHelperDelegate*

CreateWebViewPermissionHelperDelegate(

WebViewPermissionHelper* web_view_permission_helper) const OVERRIDE;

- virtual device::HidService* GetHidService() OVERRIDE;

virtual void RegisterGuestViewTypes() OVERRIDE;

private:

- scoped_ptr<device::HidService> hid_service_;

DISALLOW_COPY_AND_ASSIGN(ChromeExtensionsAPIClient);

};