Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 522303004: Add option to add precision to varyings in shader (Closed)

Created:
6 years, 3 months ago by egdaniel
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add option to add precision to varyings in shader Also use highp varying on bezier cubics to fix numerical issues for n10 and n4. BUG=skia:2860 Committed: https://skia.googlesource.com/skia/+/6db9128efb3b720252b6094dc2640796b66456aa

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change param to fsPrecision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/gpu/effects/GrBezierEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
egdaniel
This change fixes the n10 issue where cubic bezier curves didn't go all the way ...
6 years, 3 months ago (2014-09-02 14:30:29 UTC) #2
bsalomon
lgtm, w/ suggestion for param name change. https://codereview.chromium.org/522303004/diff/1/src/gpu/gl/builders/GrGLProgramBuilder.cpp File src/gpu/gl/builders/GrGLProgramBuilder.cpp (left): https://codereview.chromium.org/522303004/diff/1/src/gpu/gl/builders/GrGLProgramBuilder.cpp#oldcode347 src/gpu/gl/builders/GrGLProgramBuilder.cpp:347: fVS.addVarying(type, name, ...
6 years, 3 months ago (2014-09-02 14:46:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/522303004/20001
6 years, 3 months ago (2014-09-02 14:55:26 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 15:02:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 6db9128efb3b720252b6094dc2640796b66456aa

Powered by Google App Engine
This is Rietveld 408576698