mac, yosemite: Resize button causes fullscreen effect.

mac, yosemite: Resize button causes fullscreen effect.

In Yosemite, no views can be in front of the traffic lights controls. Move the
content view and the tab strip view to the back of the NSThemeFrame.

BUG=408094
Committed: https://crrev.com/9e9bbb50eceda9d2e4d5861b26d0b6d2e975dcfe
Cr-Commit-Position: refs/heads/master@{#293080}

[erikchen, 2014-08-30 00:53:27]

erikchen@chromium.org changed reviewers:
+ andresantoso@chromium.org

[erikchen, 2014-08-30 00:53:27]

andresantoso: Please review.

[Andre, 2014-08-30 01:38:02]

https://codereview.chromium.org/520733004/diff/60001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tabs/tab_window_controller.mm (right):

https://codereview.chromium.org/520733004/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_window_controller.mm:95: relativeTo:[[self
window] contentView]];
We also mess with tabStripView in -[BrowserWindowController
moveViewsForImmersiveFullscreen...].
Do we need to do something similar there?

[erikchen, 2014-09-02 17:35:57]

https://codereview.chromium.org/520733004/diff/60001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tabs/tab_window_controller.mm (right):

https://codereview.chromium.org/520733004/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_window_controller.mm:95: relativeTo:[[self
window] contentView]];
On 2014/08/30 01:38:02, Andre wrote:
> We also mess with tabStripView in -[BrowserWindowController
> moveViewsForImmersiveFullscreen...].
> Do we need to do something similar there?
> 

yup. also have to do something similar for making a new window from a dragged
tab.

[erikchen, 2014-09-02 18:22:34]

Patchset #2 (id:80001) has been deleted

[erikchen, 2014-09-02 18:23:03]

andresantoso: PTAL

[Andre, 2014-09-02 19:17:58]

lgtm

[erikchen, 2014-09-02 19:21:06]

erikchen@chromium.org changed reviewers:
+ shess@chromium.org

[erikchen, 2014-09-02 19:21:06]

shess: Looking for an OWNER review.

[erikchen, 2014-09-03 00:24:36]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org
- shess@chromium.org

[erikchen, 2014-09-03 00:24:37]

avi: Looking for an OWNER review.

shess is OOO for a while.

[Avi (use Gerrit), 2014-09-03 01:20:24]

lgtm

Stampity stamp with fix.

https://codereview.chromium.org/520733004/diff/100001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm (right):

https://codereview.chromium.org/520733004/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm:141: // view is
a sibling, it is directly in front fo the content view.
s/fo/of/

[erikchen, 2014-09-03 01:55:35]

https://codereview.chromium.org/520733004/diff/100001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm (right):

https://codereview.chromium.org/520733004/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm:141: // view is
a sibling, it is directly in front fo the content view.
On 2014/09/03 01:20:23, Avi wrote:
> s/fo/of/

Done.

[erikchen, 2014-09-03 01:55:38]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-03 01:58:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/520733004/120001

[commit-bot: I haz the power, 2014-09-03 02:16:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49355)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/54682)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-09-03 02:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 02:20:05]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49363)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[erikchen, 2014-09-03 02:52:01]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-03 02:53:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/520733004/140001

[commit-bot: I haz the power, 2014-09-03 06:04:25]

Committed patchset #4 (id:140001) as 5222f02591f73a2adb2fedcaad5a63c0efb8a8cd

[commit-bot: I haz the power, 2014-09-10 03:23:50]

Patchset 4 (id:??) landed as
https://crrev.com/9e9bbb50eceda9d2e4d5861b26d0b6d2e975dcfe
Cr-Commit-Position: refs/heads/master@{#293080}