Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_window_controller.h

Issue 520733004: mac, yosemite: Resize button causes fullscreen effect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase against top of tree. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tabs/tab_window_controller.h
diff --git a/chrome/browser/ui/cocoa/tabs/tab_window_controller.h b/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
index fd41a563955531acd376524b4156221cd2042e53..bed72379c55e3c1943a6d9163d5d4d69c6983486 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
+++ b/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
@@ -141,6 +141,20 @@
// during a drag.
- (void)deferPerformClose;
+// There are 2 view hierarchy constraints that must be enforced:
+// - The tab strip must be above the content view.
+// - The tab strip must be below the traffic lights.
+// AppKit does not enforce these constraints, because it assumes that Chrome
+// does not mess with the NSThemeFrame. Chrome must manually enforce these
+// constraints.
+//
+// Immediately after creation of the window, or after the window's content view
+// is changed, the content view must be moved to the back.
+- (void)moveContentViewToBack:(NSView*)contentView;
+
+// The tab strip should always be inserted directly above the content view.
+- (void)insertTabStripView:(NSView*)tabStripView intoWindow:(NSWindow*)window;
+
@end
@interface TabWindowController(ProtectedMethods)
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698