mac, yosemite: Resize button causes fullscreen effect.

chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"
 
 #include "base/logging.h"
 #import "chrome/browser/ui/cocoa/fast_resize_view.h"
 #import "chrome/browser/ui/cocoa/framed_browser_window.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
@@ skipping 70 matching lines @@
   return tabContentArea_;
 }
 
 // Add the top tab strop to the window, above the content box and add it to the
 // view hierarchy as a sibling of the content view so it can overlap with the
 // window frame.
 - (void)addTabStripToWindow {
   // The frame doesn't matter. This class relies on subclasses to do tab strip
   // layout.
   NSView* contentParent = [[self window] cr_windowView];
-  [contentParent addSubview:tabStripView_];
+  if (contentParent == [[[self window] contentView] superview]) {
+    // Add the tab strip directly above the content view, if they are siblings.
+    [contentParent addSubview:tabStripView_
+                   positioned:NSWindowAbove
+                   relativeTo:[[self window] contentView]];

[Andre, 2014/08/30 01:38:02]

We also mess with tabStripView in -[BrowserWindowController
moveViewsForImmersiveFullscreen...].
Do we need to do something similar there?

[erikchen, 2014/09/02 17:35:57]

yup. also have to do something similar for making a new window from a dragged
tab.

+  } else {
+    [contentParent addSubview:tabStripView_];
+  }
 }
 
 - (void)removeOverlay {
   [self setUseOverlay:NO];
   if (closeDeferred_) {
     // See comment in BrowserWindowCocoa::Close() about orderOut:.
     [[self window] orderOut:self];
     [[self window] performClose:self];  // Autoreleases the controller.
   }
 }
@@ skipping 190 matching lines @@
   closeDeferred_ = YES;
 }
 
 // Called when the size of the window content area has changed. Override to
 // position specific views. Base class implementation does nothing.
 - (void)layoutSubviews {
   NOTIMPLEMENTED();
 }
 
 @end