mac, yosemite: Resize button causes fullscreen effect.

chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #import "base/mac/mac_util.h"
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 10 matching lines @@
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 #import "chrome/browser/ui/cocoa/fast_resize_view.h"
 #import "chrome/browser/ui/cocoa/history_overlay_controller.h"
 #import "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h"
 #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h"
 #import "chrome/browser/ui/cocoa/nsview_additions.h"
 #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h"
 #import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h"
+#import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/web_contents.h"
 #import "testing/gtest_mac.h"
 
 namespace {
@@ skipping 86 matching lines @@
 
   CGFloat GetViewHeight(ViewID viewID) const {
     CGFloat height = NSHeight([GetViewWithID(viewID) frame]);
     if (viewID == VIEW_ID_INFO_BAR) {
       height -= [[controller() infoBarContainerController]
           overlappingTipHeight];
     }
     return height;
   }
 
+  // The traffic lights should always be in front of the content view and the
+  // tab strip view. Since the traffic lights change across OSX versions, this
+  // test verifies that the contentView is in the back, and if the tab strip
+  // view is a sibling, it is directly in front fo the content view.

[Avi (use Gerrit), 2014/09/03 01:20:23]

s/fo/of/

[erikchen, 2014/09/03 01:55:35]

Done.

+  void VerifyTrafficLightZOrder() const {
+    NSView* contentView = [[controller() window] contentView];
+    NSView* rootView = [contentView superview];
+    EXPECT_EQ(contentView, [[rootView subviews] objectAtIndex:0]);
+
+    NSView* tabStripView = [controller() tabStripView];
+    if ([[rootView subviews] containsObject:tabStripView])
+      EXPECT_EQ(tabStripView, [[rootView subviews] objectAtIndex:1]);
+  }
+
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserWindowControllerTest);
 };
 
 // Tests that adding the first profile moves the Lion fullscreen button over
 // correctly.
 // DISABLED_ because it regularly times out: http://crbug.com/159002.
 IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
                        DISABLED_ProfileAvatarFullscreenButton) {
   if (base::mac::IsOSSnowLeopard())
@@ skipping 200 matching lines @@
   DevToolsWindow* devtools_window =
       DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), true);
   DevToolsWindowTesting::Get(devtools_window)->SetInspectedPageBounds(
       gfx::Rect(10, 10, 100, 100));
 
   NSPoint originWithDevTools = [controller() statusBubbleBaseFrame].origin;
   EXPECT_FALSE(NSEqualPoints(origin, originWithDevTools));
 
   DevToolsWindowTesting::CloseDevToolsWindowSync(devtools_window);
 }
+
+IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest, TrafficLightZOrder) {
+  // Verify z order immediately after creation.
+  VerifyTrafficLightZOrder();
+
+  // Toggle overlay, then verify z order.
+  [controller() showOverlay];
+  [controller() removeOverlay];
+  VerifyTrafficLightZOrder();
+
+  // Toggle immersive fullscreen, then verify z order.
+  [controller() enterImmersiveFullscreen];
+  [controller() exitImmersiveFullscreen];
+  VerifyTrafficLightZOrder();
+}