Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2523)

Unified Diff: Source/web/FullscreenController.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/FullscreenController.h
diff --git a/Source/web/FullscreenController.h b/Source/web/FullscreenController.h
index 682d137c6c5089a95f28e8230cefc5cd69fd8f92..56a4d8f46b811e44db7191c9bd5f69043a3bb7ee 100644
--- a/Source/web/FullscreenController.h
+++ b/Source/web/FullscreenController.h
@@ -43,9 +43,9 @@ class Element;
class LocalFrame;
class WebViewImpl;
-class FullscreenController {
+class FullscreenController FINAL : public NoBaseWillBeGarbageCollected<FullscreenController> {
public:
- static PassOwnPtr<FullscreenController> create(WebViewImpl*);
+ static PassOwnPtrWillBeRawPtr<FullscreenController> create(WebViewImpl*);
void didEnterFullScreen();
void didExitFullScreen();
@@ -55,6 +55,8 @@ public:
bool isFullscreen() { return m_fullScreenFrame; }
+ void trace(Visitor*);
+
protected:
explicit FullscreenController(WebViewImpl*);
@@ -66,10 +68,10 @@ private:
FloatPoint m_exitFullscreenPinchViewportOffset;
// If set, the WebView is transitioning to fullscreen for this element.
- RefPtrWillBePersistent<Element> m_provisionalFullScreenElement;
+ RefPtrWillBeMember<Element> m_provisionalFullScreenElement;
// If set, the WebView is in fullscreen mode for an element in this frame.
- RefPtr<LocalFrame> m_fullScreenFrame;
+ RefPtrWillBeMember<LocalFrame> m_fullScreenFrame;
bool m_isCancelingFullScreen;
};
@@ -77,4 +79,3 @@ private:
} // namespace blink
#endif
-

Powered by Google App Engine
This is Rietveld 408576698