Source/web/FrameLoaderClientImpl.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index b76693c6ca71a02fbe1b40291fde72537da8624c..e97404487c4f12a58b58c8071cff77841e6f8898 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -295,7 +295,7 @@ void FrameLoaderClientImpl::detachedFromParent()

{

// Alert the client that the frame is being detached. This is the last

// chance we have to communicate with the client.

- RefPtr<WebLocalFrameImpl> protector(m_webFrame);

+ RefPtrWillBeRawPtr<WebLocalFrameImpl> protector(m_webFrame);

WebFrameClient* client = m_webFrame->client();

if (!client)

@@ -618,7 +618,7 @@ void FrameLoaderClientImpl::transitionToCommittedForNewPage()

m_webFrame->createFrameView();

}

-PassRefPtr<LocalFrame> FrameLoaderClientImpl::createFrame(

+PassRefPtrWillBeRawPtr<LocalFrame> FrameLoaderClientImpl::createFrame(

const KURL& url,

const AtomicString& name,

const Referrer& referrer,