Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: Source/web/FullscreenController.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/FullscreenController.cpp
diff --git a/Source/web/FullscreenController.cpp b/Source/web/FullscreenController.cpp
index acee2487fe291a2542e60c07d7ac52a8dcfbd037..e16af27be5dd23f69bd324e115ca684d1abf0c3a 100644
--- a/Source/web/FullscreenController.cpp
+++ b/Source/web/FullscreenController.cpp
@@ -44,9 +44,9 @@
namespace blink {
-PassOwnPtr<FullscreenController> FullscreenController::create(WebViewImpl* webViewImpl)
+PassOwnPtrWillBeRawPtr<FullscreenController> FullscreenController::create(WebViewImpl* webViewImpl)
{
- return adoptPtr(new FullscreenController(webViewImpl));
+ return adoptPtrWillBeNoop(new FullscreenController(webViewImpl));
}
FullscreenController::FullscreenController(WebViewImpl* webViewImpl)
@@ -158,5 +158,11 @@ void FullscreenController::exitFullScreenForElement(Element* element)
client->exitFullScreen();
}
+void FullscreenController::trace(Visitor* visitor)
+{
+ visitor->trace(m_provisionalFullScreenElement);
+ visitor->trace(m_fullScreenFrame);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698