Source/web/FrameLoaderClientImpl.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index 98d69ff8a72cd5521029a5dc9d7d0e90ebe8c6fb..398caf7d03eb83c3ab50a5b68ea62dc9b31f2b48 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -33,6 +33,7 @@

#define FrameLoaderClientImpl_h

#include "core/loader/FrameLoaderClient.h"

+#include "platform/heap/Handle.h"

#include "platform/weborigin/KURL.h"

#include "wtf/PassOwnPtr.h"

#include "wtf/RefPtr.h"

@@ -115,7 +116,7 @@ public:

virtual WTF::String userAgent(const KURL&) OVERRIDE;

virtual WTF::String doNotTrackValue() OVERRIDE;

virtual void transitionToCommittedForNewPage() OVERRIDE;

- virtual PassRefPtr<LocalFrame> createFrame(const KURL&, const WTF::AtomicString& name, const Referrer&, HTMLFrameOwnerElement*) OVERRIDE;

+ virtual PassRefPtrWillBeRawPtr<LocalFrame> createFrame(const KURL&, const WTF::AtomicString& name, const Referrer&, HTMLFrameOwnerElement*) OVERRIDE;

virtual bool canCreatePluginWithoutRenderer(const String& mimeType) const;

virtual PassRefPtr<Widget> createPlugin(

HTMLPlugInElement*, const KURL&,

« Source/core/xml/parser/XMLDocumentParser.cpp ('K') | « Source/web/ExternalPopupMenu.cpp ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | Source/web/WebFrame.cpp » ('J')