Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: Source/core/page/ScopedPageLoadDeferrer.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/ScopedPageLoadDeferrer.h
diff --git a/Source/core/page/ScopedPageLoadDeferrer.h b/Source/core/page/ScopedPageLoadDeferrer.h
index 144e5f5dea6b79ffb7ce82a400b7453cfba1c78b..62bcae9e2e6a4bbcd048b23e2d2de710261bbbca 100644
--- a/Source/core/page/ScopedPageLoadDeferrer.h
+++ b/Source/core/page/ScopedPageLoadDeferrer.h
@@ -20,6 +20,7 @@
#ifndef ScopedPageLoadDeferrer_h
#define ScopedPageLoadDeferrer_h
+#include "platform/heap/Handle.h"
#include "wtf/RefPtr.h"
#include "wtf/Vector.h"
@@ -28,14 +29,22 @@ namespace blink {
class LocalFrame;
class Page;
-class ScopedPageLoadDeferrer {
+class ScopedPageLoadDeferrer FINAL : public NoBaseWillBeGarbageCollectedFinalized<ScopedPageLoadDeferrer> {
haraken 2014/09/22 05:35:23 Can we add ALLOW_ONLY_INLINE_ALLOCATION() ?
sof 2014/09/22 07:25:49 Not readily; the presence of a destructor and the
WTF_MAKE_NONCOPYABLE(ScopedPageLoadDeferrer);
public:
ScopedPageLoadDeferrer(Page* exclusion = 0);
~ScopedPageLoadDeferrer();
+#if ENABLE(OILPAN)
+ void dispose();
+#endif
+
+ void trace(Visitor*);
+
private:
- Vector<RefPtr<LocalFrame>, 16> m_deferredFrames;
+ void detach();
+
+ WillBeHeapVector<RefPtrWillBeMember<LocalFrame>, 16> m_deferredFrames;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698