Source/modules/beacon/NavigatorBeacon.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/beacon/NavigatorBeacon.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/beacon/NavigatorBeacon.cpp

diff --git a/Source/modules/beacon/NavigatorBeacon.cpp b/Source/modules/beacon/NavigatorBeacon.cpp

index e02d84f79347f86348726114c3bd9864fd9fd407..48d31878acc0680b4334e363eadedfdb2cdeb666 100644

--- a/Source/modules/beacon/NavigatorBeacon.cpp

+++ b/Source/modules/beacon/NavigatorBeacon.cpp

@@ -59,7 +59,7 @@ bool NavigatorBeacon::canSendBeacon(ExecutionContext* context, const KURL& url,

}

// Do not allow sending Beacons over a Navigator that is detached.

- if (!m_navigator.frame())

+ if (!m_navigator.frame() || !m_navigator.frame()->client())

return false;

return true;