Source/core/testing/DummyPageHolder.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/DummyPageHolder.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/testing/DummyPageHolder.h

diff --git a/Source/core/testing/DummyPageHolder.h b/Source/core/testing/DummyPageHolder.h

index fe658f04a5686406bec89b5f9236929bb9f05134..554b07c26bef4925a3bca0c773b964cc375c0167 100644

--- a/Source/core/testing/DummyPageHolder.h

+++ b/Source/core/testing/DummyPageHolder.h

@@ -72,13 +72,10 @@ public:

Document& document() const;

private:

- explicit DummyPageHolder(

- const IntSize& initialViewSize,

- Page::PageClients*,

- PassOwnPtr<FrameLoaderClient>);

+ DummyPageHolder(const IntSize& initialViewSize, Page::PageClients*, PassOwnPtr<FrameLoaderClient>);

OwnPtrWillBePersistent<Page> m_page;

- RefPtr<LocalFrame> m_frame;

+ RefPtrWillBePersistent<LocalFrame> m_frame;

Page::PageClients m_pageClients;

OwnPtr<FrameLoaderClient> m_frameLoaderClient;