Source/core/testing/DummyPageHolder.h - Issue 517043003: Move Frame to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/testing/DummyPageHolder.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/page/ScopedPageLoadDeferrer.h ('K') | « Source/core/svg/graphics/SVGImage.cpp ('k') | Source/core/xml/parser/XMLDocumentParser.cpp » ('j') | Source/core/xml/parser/XMLDocumentParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013, Google Inc. All rights reserved.	2 * Copyright (c) 2013, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 Page::PageClients* = 0,	65 Page::PageClients* = 0,

66 PassOwnPtr<FrameLoaderClient> = PassOwnPtr<FrameLoaderClient>());	66 PassOwnPtr<FrameLoaderClient> = PassOwnPtr<FrameLoaderClient>());

67 ~DummyPageHolder();	67 ~DummyPageHolder();

68	68

69 Page& page() const;	69 Page& page() const;

70 LocalFrame& frame() const;	70 LocalFrame& frame() const;

71 FrameView& frameView() const;	71 FrameView& frameView() const;

72 Document& document() const;	72 Document& document() const;

73	73

74 private:	74 private:

75 explicit DummyPageHolder(	75 DummyPageHolder(const IntSize& initialViewSize, Page::PageClients*, PassOwnP tr<FrameLoaderClient>);

76 const IntSize& initialViewSize,

77 Page::PageClients*,

78 PassOwnPtr<FrameLoaderClient>);

79	76

80 OwnPtrWillBePersistent<Page> m_page;	77 OwnPtrWillBePersistent<Page> m_page;

81 RefPtr<LocalFrame> m_frame;	78 RefPtrWillBePersistent<LocalFrame> m_frame;

82	79

83 Page::PageClients m_pageClients;	80 Page::PageClients m_pageClients;

84 OwnPtr<FrameLoaderClient> m_frameLoaderClient;	81 OwnPtr<FrameLoaderClient> m_frameLoaderClient;

85 };	82 };

86	83

87 } // namespace blink	84 } // namespace blink

88	85

89 #endif // DummyPageHolder_h	86 #endif // DummyPageHolder_h

OLD	NEW