Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: Source/core/page/ScopedPageLoadDeferrer.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 */ 18 */
19 19
20 #ifndef ScopedPageLoadDeferrer_h 20 #ifndef ScopedPageLoadDeferrer_h
21 #define ScopedPageLoadDeferrer_h 21 #define ScopedPageLoadDeferrer_h
22 22
23 #include "platform/heap/Handle.h"
23 #include "wtf/RefPtr.h" 24 #include "wtf/RefPtr.h"
24 #include "wtf/Vector.h" 25 #include "wtf/Vector.h"
25 26
26 namespace blink { 27 namespace blink {
27 28
28 class LocalFrame; 29 class LocalFrame;
29 class Page; 30 class Page;
30 31
31 class ScopedPageLoadDeferrer { 32 class ScopedPageLoadDeferrer FINAL : public NoBaseWillBeGarbageCollectedFinalize d<ScopedPageLoadDeferrer> {
haraken 2014/09/22 05:35:23 Can we add ALLOW_ONLY_INLINE_ALLOCATION() ?
sof 2014/09/22 07:25:49 Not readily; the presence of a destructor and the
32 WTF_MAKE_NONCOPYABLE(ScopedPageLoadDeferrer); 33 WTF_MAKE_NONCOPYABLE(ScopedPageLoadDeferrer);
33 public: 34 public:
34 ScopedPageLoadDeferrer(Page* exclusion = 0); 35 ScopedPageLoadDeferrer(Page* exclusion = 0);
35 ~ScopedPageLoadDeferrer(); 36 ~ScopedPageLoadDeferrer();
36 37
38 #if ENABLE(OILPAN)
39 void dispose();
40 #endif
41
42 void trace(Visitor*);
43
37 private: 44 private:
38 Vector<RefPtr<LocalFrame>, 16> m_deferredFrames; 45 void detach();
46
47 WillBeHeapVector<RefPtrWillBeMember<LocalFrame>, 16> m_deferredFrames;
39 }; 48 };
40 49
41 } // namespace blink 50 } // namespace blink
42 51
43 #endif // ScopedPageLoadDeferrer_h 52 #endif // ScopedPageLoadDeferrer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698