Source/core/loader/ProgressTracker.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/ProgressTracker.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/ProgressTracker.h

diff --git a/Source/core/loader/ProgressTracker.h b/Source/core/loader/ProgressTracker.h

index 5e7188fa8885bec9cfbf4e0338c398988a41aa73..ead18ffa18172d49208880b5a659fb023509693f 100644

--- a/Source/core/loader/ProgressTracker.h

+++ b/Source/core/loader/ProgressTracker.h

@@ -66,6 +66,14 @@ private:

void reset();

+ // This bare frame pointer is safe; it refers to the

+ // owning frame (via FrameLoader.)

+ //

+ // ProgressTracker is finalized by FrameLoader (which in turn is

+ // finalized by LocalFrame.) Its lifetime thus guarantees that

+ // m_frame cannot be used to access a dead LocalFrame.

+ //

+ // FIXME: Oilpan: tidy up and move ProgressTracker to the heap.

LocalFrame* m_frame;

bool m_inProgress;

long long m_totalPageAndResourceBytesToLoad;