Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 516013003: Address review comments for r39595. (Closed)

Created:
6 years, 3 months ago by Vyacheslav Egorov (Google)
Modified:
6 years, 3 months ago
Reviewers:
srdjan, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -53 lines) Patch
M runtime/vm/deopt_instructions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.h View 1 2 chunks +12 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
PTAL
6 years, 3 months ago (2014-08-28 20:48:48 UTC) #1
srdjan
srdjan@google.com changed reviewers: + srdjan@google.com
6 years, 3 months ago (2014-08-28 22:10:46 UTC) #2
srdjan
lgtm
6 years, 3 months ago (2014-08-28 22:10:46 UTC) #3
Vyacheslav Egorov (Google)
6 years, 3 months ago (2014-08-29 11:36:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 39697 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698