Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 516013003: Address review comments for r39595. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/deopt_instructions.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc
index a00e8b99efe1c8f7d2133a56aadf0abce5920843..14bf367491c7956fb07289a5eaa90f7b7f4cf079 100644
--- a/runtime/vm/flow_graph_compiler_ia32.cc
+++ b/runtime/vm/flow_graph_compiler_ia32.cc
@@ -1577,7 +1577,7 @@ void ParallelMoveResolver::EmitMove(int index) {
if (constant.IsSmi() && (Smi::Cast(constant).Value() == 0)) {
__ xorl(destination.reg(), destination.reg());
} else if (constant.IsSmi() &&
- source.constant_instruction()->representation() == kUnboxedInt32) {
+ (source.constant_instruction()->representation() == kUnboxedInt32)) {
__ movl(destination.reg(), Immediate(Smi::Cast(constant).Value()));
} else {
__ LoadObjectSafely(destination.reg(), constant);
@@ -1614,7 +1614,7 @@ void ParallelMoveResolver::EmitMove(int index) {
ASSERT(destination.IsStackSlot());
const Object& constant = source.constant();
if (constant.IsSmi() &&
- source.constant_instruction()->representation() == kUnboxedInt32) {
+ (source.constant_instruction()->representation() == kUnboxedInt32)) {
__ movl(destination.ToStackSlotAddress(),
Immediate(Smi::Cast(constant).Value()));
} else {
« no previous file with comments | « runtime/vm/deopt_instructions.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698