runtime/vm/flow_graph_compiler_ia32.cc - Issue 516013003: Address review comments for r39595.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 516013003: Address review comments for r39595. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index a00e8b99efe1c8f7d2133a56aadf0abce5920843..14bf367491c7956fb07289a5eaa90f7b7f4cf079 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -1577,7 +1577,7 @@ void ParallelMoveResolver::EmitMove(int index) {

if (constant.IsSmi() && (Smi::Cast(constant).Value() == 0)) {

__ xorl(destination.reg(), destination.reg());

} else if (constant.IsSmi() &&

- source.constant_instruction()->representation() == kUnboxedInt32) {

+ (source.constant_instruction()->representation() == kUnboxedInt32)) {

__ movl(destination.reg(), Immediate(Smi::Cast(constant).Value()));

} else {

__ LoadObjectSafely(destination.reg(), constant);

@@ -1614,7 +1614,7 @@ void ParallelMoveResolver::EmitMove(int index) {

ASSERT(destination.IsStackSlot());

const Object& constant = source.constant();

if (constant.IsSmi() &&

- source.constant_instruction()->representation() == kUnboxedInt32) {

+ (source.constant_instruction()->representation() == kUnboxedInt32)) {

__ movl(destination.ToStackSlotAddress(),

Immediate(Smi::Cast(constant).Value()));

} else {

« no previous file with comments | « runtime/vm/deopt_instructions.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »