Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: runtime/vm/flow_graph_range_analysis.cc

Issue 516013003: Address review comments for r39595. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_range_analysis.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_range_analysis.cc
diff --git a/runtime/vm/flow_graph_range_analysis.cc b/runtime/vm/flow_graph_range_analysis.cc
index cad20f7ad1b9cdfc0873095ae663916f5ecb93d7..be3e1e8b6b6fddde8f4c5117410f616c24d1acb9 100644
--- a/runtime/vm/flow_graph_range_analysis.cc
+++ b/runtime/vm/flow_graph_range_analysis.cc
@@ -687,10 +687,10 @@ void RangeAnalysis::RemoveConstraints() {
static void NarrowBinaryMintOp(BinaryMintOpInstr* mint_op) {
- if (Range::Fits(mint_op->range(), RangeBoundary::kRangeBoundaryInt32) &&
- Range::Fits(mint_op->left()->definition()->range(),
+ if (RangeUtils::Fits(mint_op->range(), RangeBoundary::kRangeBoundaryInt32) &&
+ RangeUtils::Fits(mint_op->left()->definition()->range(),
RangeBoundary::kRangeBoundaryInt32) &&
- Range::Fits(mint_op->right()->definition()->range(),
+ RangeUtils::Fits(mint_op->right()->definition()->range(),
RangeBoundary::kRangeBoundaryInt32) &&
BinaryInt32OpInstr::IsSupported(mint_op->op_kind(),
mint_op->left(),
@@ -708,10 +708,10 @@ static void NarrowBinaryMintOp(BinaryMintOpInstr* mint_op) {
static void NarrowShiftMintOp(ShiftMintOpInstr* mint_op) {
- if (Range::Fits(mint_op->range(), RangeBoundary::kRangeBoundaryInt32) &&
- Range::Fits(mint_op->left()->definition()->range(),
+ if (RangeUtils::Fits(mint_op->range(), RangeBoundary::kRangeBoundaryInt32) &&
+ RangeUtils::Fits(mint_op->left()->definition()->range(),
RangeBoundary::kRangeBoundaryInt32) &&
- Range::Fits(mint_op->right()->definition()->range(),
+ RangeUtils::Fits(mint_op->right()->definition()->range(),
RangeBoundary::kRangeBoundaryInt32) &&
BinaryInt32OpInstr::IsSupported(mint_op->op_kind(),
mint_op->left(),
« no previous file with comments | « runtime/vm/flow_graph_range_analysis.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698