runtime/vm/flow_graph_range_analysis.cc - Issue 516013003: Address review comments for r39595.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_range_analysis.cc

Issue 516013003: Address review comments for r39595. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_range_analysis.cc

diff --git a/runtime/vm/flow_graph_range_analysis.cc b/runtime/vm/flow_graph_range_analysis.cc

index cad20f7ad1b9cdfc0873095ae663916f5ecb93d7..be3e1e8b6b6fddde8f4c5117410f616c24d1acb9 100644

--- a/runtime/vm/flow_graph_range_analysis.cc

+++ b/runtime/vm/flow_graph_range_analysis.cc

@@ -687,10 +687,10 @@ void RangeAnalysis::RemoveConstraints() {

static void NarrowBinaryMintOp(BinaryMintOpInstr* mint_op) {

- if (Range::Fits(mint_op->range(), RangeBoundary::kRangeBoundaryInt32) &&

- Range::Fits(mint_op->left()->definition()->range(),

+ if (RangeUtils::Fits(mint_op->range(), RangeBoundary::kRangeBoundaryInt32) &&

+ RangeUtils::Fits(mint_op->left()->definition()->range(),

RangeBoundary::kRangeBoundaryInt32) &&

- Range::Fits(mint_op->right()->definition()->range(),

+ RangeUtils::Fits(mint_op->right()->definition()->range(),

RangeBoundary::kRangeBoundaryInt32) &&

BinaryInt32OpInstr::IsSupported(mint_op->op_kind(),

mint_op->left(),

@@ -708,10 +708,10 @@ static void NarrowBinaryMintOp(BinaryMintOpInstr* mint_op) {

static void NarrowShiftMintOp(ShiftMintOpInstr* mint_op) {

- if (Range::Fits(mint_op->range(), RangeBoundary::kRangeBoundaryInt32) &&

- Range::Fits(mint_op->left()->definition()->range(),

+ if (RangeUtils::Fits(mint_op->range(), RangeBoundary::kRangeBoundaryInt32) &&

+ RangeUtils::Fits(mint_op->left()->definition()->range(),

RangeBoundary::kRangeBoundaryInt32) &&

- Range::Fits(mint_op->right()->definition()->range(),

+ RangeUtils::Fits(mint_op->right()->definition()->range(),

RangeBoundary::kRangeBoundaryInt32) &&

BinaryInt32OpInstr::IsSupported(mint_op->op_kind(),

mint_op->left(),

« no previous file with comments | « runtime/vm/flow_graph_range_analysis.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »