Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: runtime/vm/flow_graph_range_analysis.h

Issue 516013003: Address review comments for r39595. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/flow_graph_range_analysis.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_range_analysis.h
diff --git a/runtime/vm/flow_graph_range_analysis.h b/runtime/vm/flow_graph_range_analysis.h
index d81538550f3faef723338099720a92430ddd07e3..fa07e6037826d31a0915fa74e35026a9d06e51f5 100644
--- a/runtime/vm/flow_graph_range_analysis.h
+++ b/runtime/vm/flow_graph_range_analysis.h
@@ -425,10 +425,6 @@ class Range : public ZoneAllocated {
!max().UpperBound().Overflowed(size);
}
- static bool Fits(Range* range, RangeBoundary::RangeSize size) {
- return !IsUnknown(range) && range->Fits(size);
- }
-
// Clamp this to be within size.
void Clamp(RangeBoundary::RangeSize size);
@@ -485,6 +481,18 @@ class Range : public ZoneAllocated {
};
+class RangeUtils : public AllStatic {
+ public:
+ static bool Fits(Range* range, RangeBoundary::RangeSize size) {
+ return !Range::IsUnknown(range) && range->Fits(size);
+ }
+
+ static bool IsWithin(Range* range, int64_t min, int64_t max) {
+ return !Range::IsUnknown(range) && range->IsWithin(min, max);
+ }
+};
+
+
// Range analysis for integer values.
class RangeAnalysis : public ValueObject {
public:
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/flow_graph_range_analysis.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698