Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 511643002: BrowserPlugin: Simplify guest access (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

BrowserPlugin: Simplify guest access Now that it's impossible for content to create guests and it's impossible for a compromised embedder to access a guest it does not have permission to access from content, BrowserPluginGuestManager::MaybeGetGuestByInstanceIDOrKill seems a bit heavy-handed. This CL simplifies the API a bit. This is also a prerequiste to support accessibility in BrowserPlugin. BUG=226145 Committed: https://crrev.com/986f59179731e7970d99d9e8d1a7de43719c73bc Cr-Commit-Position: refs/heads/master@{#292060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -70 lines) Patch
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 chunk +8 lines, -18 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.cc View 2 chunks +11 lines, -14 lines 0 comments Download
M content/public/browser/browser_plugin_guest_manager.h View 1 chunk +4 lines, -9 lines 0 comments Download
M content/public/browser/browser_plugin_guest_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.h View 2 chunks +3 lines, -5 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.cc View 1 chunk +8 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Fady Samuel
fsamuel@chromium.org changed reviewers: + creis@chromium.org
6 years, 3 months ago (2014-08-26 22:41:24 UTC) #1
Fady Samuel
H Charlie, This is the change we talked about offline in email as a prerequisite ...
6 years, 3 months ago (2014-08-26 22:41:24 UTC) #2
Charlie Reis
Thanks! LGTM.
6 years, 3 months ago (2014-08-26 23:50:36 UTC) #3
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 3 months ago (2014-08-26 23:56:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/511643002/1
6 years, 3 months ago (2014-08-26 23:58:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as c026f9fd691678ed87b91312f57545b2bc811468
6 years, 3 months ago (2014-08-27 01:11:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/986f59179731e7970d99d9e8d1a7de43719c73bc
Cr-Commit-Position: refs/heads/master@{#292060}

Powered by Google App Engine
This is Rietveld 408576698