Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: content/browser/browser_plugin/browser_plugin_message_filter.cc

Issue 511643002: BrowserPlugin: Simplify guest access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_message_filter.cc
diff --git a/content/browser/browser_plugin/browser_plugin_message_filter.cc b/content/browser/browser_plugin/browser_plugin_message_filter.cc
index d18e0291fcf6acffc6e1b3add443ac72fb79ae65..da0de0f0d64c16dee27fb3bccdf84a54310997eb 100644
--- a/content/browser/browser_plugin/browser_plugin_message_filter.cc
+++ b/content/browser/browser_plugin/browser_plugin_message_filter.cc
@@ -59,14 +59,6 @@ void BrowserPluginMessageFilter::OverrideThreadForMessage(
*thread = BrowserThread::UI;
}
-static void BrowserPluginGuestMessageCallback(const IPC::Message& message,
- WebContents* guest_web_contents) {
- if (!guest_web_contents)
- return;
- static_cast<WebContentsImpl*>(guest_web_contents)->GetBrowserPluginGuest()->
- OnMessageReceivedFromEmbedder(message);
-}
-
void BrowserPluginMessageFilter::ForwardMessageToGuest(
const IPC::Message& message) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -82,12 +74,17 @@ void BrowserPluginMessageFilter::ForwardMessageToGuest(
PickleIterator iter(message);
bool success = iter.ReadInt(&browser_plugin_instance_id);
DCHECK(success);
- embedder_web_contents->GetBrowserContext()->GetGuestManager()->
- MaybeGetGuestByInstanceIDOrKill(
- embedder_web_contents,
- browser_plugin_instance_id,
- base::Bind(&BrowserPluginGuestMessageCallback,
- message));
+ WebContents* guest_web_contents =
+ embedder_web_contents->GetBrowserContext()
+ ->GetGuestManager()
+ ->GetGuestByInstanceID(embedder_web_contents,
+ browser_plugin_instance_id);
+ if (!guest_web_contents)
+ return;
+
+ static_cast<WebContentsImpl*>(guest_web_contents)
+ ->GetBrowserPluginGuest()
+ ->OnMessageReceivedFromEmbedder(message);
}
void BrowserPluginMessageFilter::OnSwapBuffersACK(
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/public/browser/browser_plugin_guest_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698