Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/public/browser/browser_plugin_guest_manager.h

Issue 511643002: BrowserPlugin: Simplify guest access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/browser_plugin_guest_manager.h
diff --git a/content/public/browser/browser_plugin_guest_manager.h b/content/public/browser/browser_plugin_guest_manager.h
index f56cd2abfef86c4e809f4dcc9ba55146de23a130..ca53944630b83fa6d49437613b49710bda7c8e4c 100644
--- a/content/public/browser/browser_plugin_guest_manager.h
+++ b/content/public/browser/browser_plugin_guest_manager.h
@@ -29,15 +29,10 @@ class CONTENT_EXPORT BrowserPluginGuestManager {
typedef base::Callback<void(WebContents*)> GuestByInstanceIDCallback;
// Requests a guest WebContents associated with the provided
- // |guest_instance_id|. If a guest associated with the provided ID
- // does not exist, then the |callback| will be called with a NULL
- // WebContents. If the provided |embedder_render_process_id| does
- // not own the requested guest, then the embedder will be killed,
- // and the |callback| will not be called.
- virtual void MaybeGetGuestByInstanceIDOrKill(
- WebContents* embedder_web_contents,
- int browser_plugin_instance_id,
- const GuestByInstanceIDCallback& callback) {}
+ // |browser_plugin_instance_id|.
+ // Returns the guest associated with the provided ID if one exists.
+ virtual WebContents* GetGuestByInstanceID(WebContents* embedder_web_contents,
+ int browser_plugin_instance_id);
// Iterates over all WebContents belonging to a given |embedder_web_contents|,
// calling |callback| for each. If one of the callbacks returns true, then

Powered by Google App Engine
This is Rietveld 408576698