Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: extensions/browser/guest_view/guest_view_manager.cc

Issue 511643002: BrowserPlugin: Simplify guest access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/guest_view_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/guest_view_manager.cc
diff --git a/extensions/browser/guest_view/guest_view_manager.cc b/extensions/browser/guest_view/guest_view_manager.cc
index 11acf2e58063887df314caa5770caadd394fd952..9403730540f78410213a302453be51d657bd87a3 100644
--- a/extensions/browser/guest_view/guest_view_manager.cc
+++ b/extensions/browser/guest_view/guest_view_manager.cc
@@ -148,27 +148,18 @@ content::WebContents* GuestViewManager::CreateGuestWithWebContentsParams(
return guest_web_contents;
}
-void GuestViewManager::MaybeGetGuestByInstanceIDOrKill(
+content::WebContents* GuestViewManager::GetGuestByInstanceID(
content::WebContents* embedder_web_contents,
- int element_instance_id,
- const GuestByInstanceIDCallback& callback) {
- int guest_instance_id = GetGuestInstanceIDForPluginID(embedder_web_contents,
- element_instance_id);
+ int element_instance_id) {
+ int guest_instance_id = GetGuestInstanceIDForElementID(embedder_web_contents,
+ element_instance_id);
if (guest_instance_id == guestview::kInstanceIDNone)
- return;
- int embedder_render_process_id =
- embedder_web_contents->GetRenderProcessHost()->GetID();
- if (!CanEmbedderAccessInstanceIDMaybeKill(embedder_render_process_id,
- guest_instance_id)) {
- // If we kill the embedder, then don't bother calling back.
- return;
- }
- content::WebContents* guest_web_contents =
- GetGuestByInstanceID(guest_instance_id);
- callback.Run(guest_web_contents);
+ return NULL;
+
+ return GetGuestByInstanceID(guest_instance_id);
}
-int GuestViewManager::GetGuestInstanceIDForPluginID(
+int GuestViewManager::GetGuestInstanceIDForElementID(
content::WebContents* embedder_web_contents,
int element_instance_id) {
GuestInstanceIDMap::iterator iter = instance_id_map_.find(
« no previous file with comments | « extensions/browser/guest_view/guest_view_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698